Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.h

Issue 648803002: Fix outstanding request stats for multiple transfer navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix review suggestions Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/loader/resource_dispatcher_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/resource_dispatcher_host_impl.h
diff --git a/content/browser/loader/resource_dispatcher_host_impl.h b/content/browser/loader/resource_dispatcher_host_impl.h
index b4548badd1cc14dc6af7557853f3fbf6cae4fcdb..91a384bf4b174aae9300027604aa999500e0c01c 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.h
+++ b/content/browser/loader/resource_dispatcher_host_impl.h
@@ -249,12 +249,12 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl
// sending it to the renderer. Returns true if there are enough file
// descriptors available for the shared memory buffer. If false is returned,
// the request should cancel.
- bool HasSufficientResourcesForRequest(const net::URLRequest* request_);
+ bool HasSufficientResourcesForRequest(net::URLRequest* request);
// Called by a ResourceHandler after it has finished its request and is done
// using its shared memory buffer. Frees up that file descriptor to be used
// elsewhere.
- void FinishedWithResourcesForRequest(const net::URLRequest* request_);
+ void FinishedWithResourcesForRequest(net::URLRequest* request);
// PlzNavigate
// Called by NavigationRequest to start a navigation request in the node
@@ -343,12 +343,12 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl
int count,
const ResourceRequestInfoImpl& info);
- // Called every time an in flight request is issued or finished. |count|
- // indicates whether the request is issuing or finishing. |count| must be 1
- // or -1.
+ // Called when an in flight request allocates or releases a shared memory
+ // buffer. |count| indicates whether the request is issuing or finishing.
+ // |count| must be 1 or -1.
OustandingRequestsStats IncrementOutstandingRequestsCount(
int count,
- const ResourceRequestInfoImpl& info);
+ ResourceRequestInfoImpl* info);
// Estimate how much heap space |request| will consume to run.
static int CalculateApproximateMemoryCost(net::URLRequest* request);
« no previous file with comments | « no previous file | content/browser/loader/resource_dispatcher_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698