Fix outstanding request stats for multiple transfer navigations.

content/browser/loader/resource_dispatcher_host_impl.h

Index: content/browser/loader/resource_dispatcher_host_impl.h
diff --git a/content/browser/loader/resource_dispatcher_host_impl.h b/content/browser/loader/resource_dispatcher_host_impl.h
index b4548badd1cc14dc6af7557853f3fbf6cae4fcdb..7a1054ec1d6f567f8a4d255ba23a787c3700652d 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.h
+++ b/content/browser/loader/resource_dispatcher_host_impl.h
@@ -249,12 +249,12 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl
   // sending it to the renderer. Returns true if there are enough file
   // descriptors available for the shared memory buffer. If false is returned,
   // the request should cancel.
-  bool HasSufficientResourcesForRequest(const net::URLRequest* request_);

[Charlie Reis, 2014/10/14 23:54:12]

No idea how |request_| slipped in as a parameter name.

+  bool HasSufficientResourcesForRequest(net::URLRequest* request);
 
   // Called by a ResourceHandler after it has finished its request and is done
   // using its shared memory buffer. Frees up that file descriptor to be used
   // elsewhere.
-  void FinishedWithResourcesForRequest(const net::URLRequest* request_);
+  void FinishedWithResourcesForRequest(net::URLRequest* request);
 
   // PlzNavigate
   // Called by NavigationRequest to start a navigation request in the node
@@ -343,12 +343,12 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl
       int count,
       const ResourceRequestInfoImpl& info);
 
-  // Called every time an in flight request is issued or finished. |count|
-  // indicates whether the request is issuing or finishing. |count| must be 1
-  // or -1.
+  // Called when in flight requests that require file descriptors for their
+  // shared memory buffers are issued or finished. |count| indicates whether the

[davidben, 2014/10/15 19:15:12]

First sentence should probably say:

  Called when an flight request allocates or releases a shared memory buffer.

It's not allocated when the request is issued. Just when we first need the
buffer in ARH::OnWillRead. (I guess another option would be to count it ahead of
time because the RDH knows which requests end at ARHs and which end at different
leaf handlers. The current logic delays until we start reading the response
body.)

[Charlie Reis, 2014/10/15 19:48:00]

Done.

+  // request is issuing or finishing. |count| must be 1 or -1.
   OustandingRequestsStats IncrementOutstandingRequestsCount(
       int count,
-      const ResourceRequestInfoImpl& info);
+      ResourceRequestInfoImpl& info);
 
   // Estimate how much heap space |request| will consume to run.
   static int CalculateApproximateMemoryCost(net::URLRequest* request);