Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Issue 648783002: Use new gclient config to pull V8 bleeding edge revisions. (Closed)

Created:
6 years, 2 months ago by prasadv
Modified:
6 years, 2 months ago
Reviewers:
tonyg, qyearsley, hinoka
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use new gclient config to pull V8 bleeding edge revisions. BUG=422386 NOTRY=true Committed: https://crrev.com/68593e0bd3d3ca1301ee3a0a2dc3f615ad5e369d Cr-Commit-Position: refs/heads/master@{#299190}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/auto_bisect/bisect_utils.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
prasadv
6 years, 2 months ago (2014-10-10 17:15:37 UTC) #2
hinoka
https://codereview.chromium.org/648783002/diff/30001/tools/auto_bisect/bisect_utils.py File tools/auto_bisect/bisect_utils.py (right): https://codereview.chromium.org/648783002/diff/30001/tools/auto_bisect/bisect_utils.py#newcode64 tools/auto_bisect/bisect_utils.py:64: 'src/v8_bleeding_edge': 'git://github.com/v8/v8-git-mirror.git' Why not https://chromium.googlesource.com/v8/v8.git? Thats the one listed ...
6 years, 2 months ago (2014-10-10 17:59:47 UTC) #3
tonyg
https://codereview.chromium.org/648783002/diff/30001/tools/auto_bisect/bisect_utils.py File tools/auto_bisect/bisect_utils.py (right): https://codereview.chromium.org/648783002/diff/30001/tools/auto_bisect/bisect_utils.py#newcode64 tools/auto_bisect/bisect_utils.py:64: 'src/v8_bleeding_edge': 'git://github.com/v8/v8-git-mirror.git' On 2014/10/10 17:59:47, hinoka wrote: > Why ...
6 years, 2 months ago (2014-10-10 18:28:15 UTC) #4
prasadv
https://codereview.chromium.org/648783002/diff/30001/tools/auto_bisect/bisect_utils.py File tools/auto_bisect/bisect_utils.py (right): https://codereview.chromium.org/648783002/diff/30001/tools/auto_bisect/bisect_utils.py#newcode64 tools/auto_bisect/bisect_utils.py:64: 'src/v8_bleeding_edge': 'git://github.com/v8/v8-git-mirror.git' On 2014/10/10 17:59:47, hinoka wrote: > Why ...
6 years, 2 months ago (2014-10-10 20:55:51 UTC) #5
hinoka
lgtm
6 years, 2 months ago (2014-10-10 21:29:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648783002/120001
6 years, 2 months ago (2014-10-10 21:31:20 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:120001)
6 years, 2 months ago (2014-10-10 21:32:56 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 21:33:52 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/68593e0bd3d3ca1301ee3a0a2dc3f615ad5e369d
Cr-Commit-Position: refs/heads/master@{#299190}

Powered by Google App Engine
This is Rietveld 408576698