Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 648763003: [NaCl SDK] nacl_io: Mask mode before passing to Node::SetMode (Closed)

Created:
6 years, 2 months ago by binji
Modified:
6 years, 2 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: Mask mode before passing to Node::SetMode This prevents an assert when running in debug mode. BUG=none R=sbc@chromium.org Committed: https://crrev.com/1402ba0b981f0496f7d7fb282f5b7fc51abd3a68 Cr-Commit-Position: refs/heads/master@{#299382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M native_client_sdk/src/libraries/nacl_io/dir_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
6 years, 2 months ago (2014-10-13 19:43:02 UTC) #1
Sam Clegg
lgtm
6 years, 2 months ago (2014-10-13 20:11:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648763003/1
6 years, 2 months ago (2014-10-13 21:46:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 22:52:57 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 22:53:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1402ba0b981f0496f7d7fb282f5b7fc51abd3a68
Cr-Commit-Position: refs/heads/master@{#299382}

Powered by Google App Engine
This is Rietveld 408576698