Implement ScreenOrientationDelegate on ChromeOS

ash/system/chromeos/screen_orientation/screen_orientation_delegate_ash.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/system/chromeos/screen_orientation/screen_orientation_delegate_ash.h"
+
+#include "ash/shell.h"
+#include "ash/wm/maximize_mode/maximize_mode_controller.h"
+#include "content/public/browser/screen_orientation_provider.h"
+#include "ui/gfx/display.h"
+
+namespace ash {
+
+ScreenOrientationDelegateAsh::ScreenOrientationDelegateAsh() {
+  content::ScreenOrientationProvider::SetDelegate(this);
+}
+
+ScreenOrientationDelegateAsh::~ScreenOrientationDelegateAsh() {
+  content::ScreenOrientationProvider::SetDelegate(NULL);
+}
+
+bool ScreenOrientationDelegateAsh::FullScreenRequired(
+    content::WebContents* web_contents) {
+  return true;
+}
+
+void ScreenOrientationDelegateAsh::Lock(
+    blink::WebScreenOrientationLockType lock_orientation) {
+  MaximizeModeController* controller =
+      Shell::GetInstance()->maximize_mode_controller();
+  switch (lock_orientation) {
+    case blink::WebScreenOrientationLockDefault:
+      controller->SetRotationLocked(false);

[mlamouri (slow - plz ping), 2014/10/13 09:45:44]

Why not, but technically, that should not happen. Why not having a DCHECK?

[jonross, 2014/10/14 19:38:04]

Done.

+      break;
+    case blink::WebScreenOrientationLockPortraitPrimary:
+    case blink::WebScreenOrientationLockPortrait:
+      controller->LockRotation(gfx::Display::ROTATE_90);

[mlamouri (slow - plz ping), 2014/10/13 09:45:44]

Two things worry me here:
1. we should allow rotating from 'portrait-primary' to 'portrait-secondary' if
locked in 'portrait';
2. you are making assumption about the device natural orientation

[jonross, 2014/10/14 14:46:57]

1) Had not realized that. The ChromeOS user rotation currently does not allow
that. I'll check with UX to see how we would have to update our lock
notifications.
2) Yes these are some assumptions for natural orientation. Would you have
recommendations on determining this?

[jonross, 2014/10/14 19:38:04]

Done.

+      break;
+    case blink::WebScreenOrientationLockPortraitSecondary:
+      controller->LockRotation(gfx::Display::ROTATE_270);
+    case blink::WebScreenOrientationLockLandscapeSecondary:
+      controller->LockRotation(gfx::Display::ROTATE_180);

[mlamouri (slow - plz ping), 2014/10/13 09:45:44]

Same regarding the natural orientation for the 'portrait-secondary' and
'landscape-secondary'.

+      break;
+    case blink::WebScreenOrientationLockAny:
+      controller->SetRotationLocked(true);

[mlamouri (slow - plz ping), 2014/10/13 09:45:44]

'any' doesn't mean locked to the current orientation but allow all orientations
to be used. Is that the unlocked behaviour on ChromeOS?

[jonross, 2014/10/14 19:38:04]

Correct it is unlocked. Merging with the DCHEcK for LockDefault, as they should
both be unlocked states.

+      break;
+    case blink::WebScreenOrientationLockLandscapePrimary:
+    case blink::WebScreenOrientationLockLandscape:
+    case blink::WebScreenOrientationLockNatural:
+    default:
+      controller->LockRotation(gfx::Display::ROTATE_0);

[mlamouri (slow - plz ping), 2014/10/13 09:45:44]

Same comment regarding the natural orientation.

[jonross, 2014/10/14 19:38:04]

Done.

+      break;
+  }
+}
+
+bool ScreenOrientationDelegateAsh::ScreenOrientationProviderSupported() {
+  return Shell::GetInstance()->maximize_mode_controller()->
+      IsMaximizeModeWindowManagerEnabled();
+}
+
+void ScreenOrientationDelegateAsh::Unlock() {
+  Shell::GetInstance()->maximize_mode_controller()->SetRotationLocked(false);
+}
+
+}  // namespace ash