Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 648683003: mojo: Add maps to java bindings. (Closed)

Created:
6 years, 2 months ago by qsr
Modified:
6 years, 2 months ago
Reviewers:
Elliot Glaysher, ppi
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Add maps to java bindings. BUG=413863 R=ppi@chromium.org,erg@chromium.org Committed: https://crrev.com/a456ad3f2208af7d4f529a25d33354ae2626cfd3 Cr-Commit-Position: refs/heads/master@{#299295}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Examples #

Patch Set 3 : Example with maps #

Patch Set 4 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -23 lines) Patch
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java View 1 2 3 3 chunks +12 lines, -6 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Encoder.java View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl View 1 chunk +36 lines, -12 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_java_generator.py View 5 chunks +22 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
qsr
6 years, 2 months ago (2014-10-10 15:21:27 UTC) #1
Elliot Glaysher
I don't have any useful comments (I've written maybe 5k lines of java ever), but ...
6 years, 2 months ago (2014-10-10 19:06:34 UTC) #2
ppi
https://codereview.chromium.org/648683003/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java File mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java (right): https://codereview.chromium.org/648683003/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java#newcode152 mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java:152: if (si.size != 24) { Should we move MAP_STRUCT_HEADER ...
6 years, 2 months ago (2014-10-13 11:11:32 UTC) #3
qsr
https://codereview.chromium.org/648683003/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java File mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java (right): https://codereview.chromium.org/648683003/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java#newcode152 mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java:152: if (si.size != 24) { On 2014/10/13 11:11:32, ppi ...
6 years, 2 months ago (2014-10-13 11:53:51 UTC) #4
ppi
lgtm
6 years, 2 months ago (2014-10-13 12:34:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648683003/420001
6 years, 2 months ago (2014-10-13 12:42:39 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:420001)
6 years, 2 months ago (2014-10-13 13:55:40 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 13:56:26 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a456ad3f2208af7d4f529a25d33354ae2626cfd3
Cr-Commit-Position: refs/heads/master@{#299295}

Powered by Google App Engine
This is Rietveld 408576698