Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 648673002: Content Shell: Introduce LayoutTestDownloadManagerDelegate. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@637843003
Project:
chromium
Visibility:
Public.

Description

Content Shell: Introduce LayoutTestDownloadManagerDelegate. This patch moves the DRT-specific bits of ShellDownloadManagerDelegate into a new layout-test-only subclass. BUG=420994 Committed: https://crrev.com/c639ead18a3f710cade31c9dd7ff383fc731a5c4 Cr-Commit-Position: refs/heads/master@{#299107}

Patch Set 1 : Ugh. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -11 lines) Patch
M content/content_shell.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_context.cc View 2 chunks +2 lines, -4 lines 1 comment Download
A content/shell/browser/layout_test/layout_test_download_manager_delegate.h View 1 chunk +34 lines, -0 lines 0 comments Download
A content/shell/browser/layout_test/layout_test_download_manager_delegate.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M content/shell/browser/shell_download_manager_delegate.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mike West
WDYT, Jochen? This depends on re-landing https://codereview.chromium.org/641343002/. I'll throw it at the bots once that ...
6 years, 2 months ago (2014-10-10 11:11:47 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-10 11:18:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648673002/60001
6 years, 2 months ago (2014-10-10 11:46:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:60001)
6 years, 2 months ago (2014-10-10 13:53:52 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 13:54:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c639ead18a3f710cade31c9dd7ff383fc731a5c4
Cr-Commit-Position: refs/heads/master@{#299107}

Powered by Google App Engine
This is Rietveld 408576698