Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: chrome/browser/undo/bookmark_undo_service.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/undo/bookmark_undo_service.h ('k') | chrome/browser/undo/bookmark_undo_service_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/undo/bookmark_undo_service.cc
diff --git a/chrome/browser/undo/bookmark_undo_service.cc b/chrome/browser/undo/bookmark_undo_service.cc
index ff7f44f3d525b1caf58470f1bee89cc0a09e895b..d763bdb940e060696f77c6cb4d0c601ef959e76b 100644
--- a/chrome/browser/undo/bookmark_undo_service.cc
+++ b/chrome/browser/undo/bookmark_undo_service.cc
@@ -27,7 +27,7 @@ class BookmarkUndoOperation : public UndoOperation,
public BookmarkRenumberObserver {
public:
explicit BookmarkUndoOperation(Profile* profile);
- virtual ~BookmarkUndoOperation() {}
+ ~BookmarkUndoOperation() override {}
BookmarkModel* GetBookmarkModel() const;
BookmarkRenumberObserver* GetUndoRenumberObserver() const;
@@ -55,15 +55,15 @@ BookmarkRenumberObserver* BookmarkUndoOperation::GetUndoRenumberObserver()
class BookmarkAddOperation : public BookmarkUndoOperation {
public:
BookmarkAddOperation(Profile* profile, const BookmarkNode* parent, int index);
- virtual ~BookmarkAddOperation() {}
+ ~BookmarkAddOperation() override {}
// UndoOperation:
- virtual void Undo() override;
- virtual int GetUndoLabelId() const override;
- virtual int GetRedoLabelId() const override;
+ void Undo() override;
+ int GetUndoLabelId() const override;
+ int GetRedoLabelId() const override;
// BookmarkRenumberObserver:
- virtual void OnBookmarkRenumbered(int64 old_id, int64 new_id) override;
+ void OnBookmarkRenumbered(int64 old_id, int64 new_id) override;
private:
int64 parent_id_;
@@ -114,15 +114,15 @@ class BookmarkRemoveOperation : public BookmarkUndoOperation {
const BookmarkNode* parent,
int old_index,
const BookmarkNode* node);
- virtual ~BookmarkRemoveOperation() {}
+ ~BookmarkRemoveOperation() override {}
// UndoOperation:
- virtual void Undo() override;
- virtual int GetUndoLabelId() const override;
- virtual int GetRedoLabelId() const override;
+ void Undo() override;
+ int GetUndoLabelId() const override;
+ int GetRedoLabelId() const override;
// BookmarkRenumberObserver:
- virtual void OnBookmarkRenumbered(int64 old_id, int64 new_id) override;
+ void OnBookmarkRenumbered(int64 old_id, int64 new_id) override;
private:
void UpdateBookmarkIds(const BookmarkNodeData::Element& element,
@@ -191,15 +191,15 @@ class BookmarkEditOperation : public BookmarkUndoOperation {
public:
BookmarkEditOperation(Profile* profile,
const BookmarkNode* node);
- virtual ~BookmarkEditOperation() {}
+ ~BookmarkEditOperation() override {}
// UndoOperation:
- virtual void Undo() override;
- virtual int GetUndoLabelId() const override;
- virtual int GetRedoLabelId() const override;
+ void Undo() override;
+ int GetUndoLabelId() const override;
+ int GetRedoLabelId() const override;
// BookmarkRenumberObserver:
- virtual void OnBookmarkRenumbered(int64 old_id, int64 new_id) override;
+ void OnBookmarkRenumbered(int64 old_id, int64 new_id) override;
private:
int64 node_id_;
@@ -249,15 +249,15 @@ class BookmarkMoveOperation : public BookmarkUndoOperation {
int old_index,
const BookmarkNode* new_parent,
int new_index);
- virtual ~BookmarkMoveOperation() {}
- virtual int GetUndoLabelId() const override;
- virtual int GetRedoLabelId() const override;
+ ~BookmarkMoveOperation() override {}
+ int GetUndoLabelId() const override;
+ int GetRedoLabelId() const override;
// UndoOperation:
- virtual void Undo() override;
+ void Undo() override;
// BookmarkRenumberObserver:
- virtual void OnBookmarkRenumbered(int64 old_id, int64 new_id) override;
+ void OnBookmarkRenumbered(int64 old_id, int64 new_id) override;
private:
int64 old_parent_id_;
@@ -326,15 +326,15 @@ class BookmarkReorderOperation : public BookmarkUndoOperation {
public:
BookmarkReorderOperation(Profile* profile,
const BookmarkNode* parent);
- virtual ~BookmarkReorderOperation();
+ ~BookmarkReorderOperation() override;
// UndoOperation:
- virtual void Undo() override;
- virtual int GetUndoLabelId() const override;
- virtual int GetRedoLabelId() const override;
+ void Undo() override;
+ int GetUndoLabelId() const override;
+ int GetRedoLabelId() const override;
// BookmarkRenumberObserver:
- virtual void OnBookmarkRenumbered(int64 old_id, int64 new_id) override;
+ void OnBookmarkRenumbered(int64 old_id, int64 new_id) override;
private:
int64 parent_id_;
« no previous file with comments | « chrome/browser/undo/bookmark_undo_service.h ('k') | chrome/browser/undo/bookmark_undo_service_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698