Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: chrome/browser/translate/chrome_translate_client.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/chrome_translate_client.h
diff --git a/chrome/browser/translate/chrome_translate_client.h b/chrome/browser/translate/chrome_translate_client.h
index 2ba5e3405d3cbfdfb746516b55dc6f1b002a4e65..1d2a7ee166fa4372b4e2c51804ebc6fd38c86a27 100644
--- a/chrome/browser/translate/chrome_translate_client.h
+++ b/chrome/browser/translate/chrome_translate_client.h
@@ -41,7 +41,7 @@ class ChromeTranslateClient
public content::WebContentsObserver,
public content::WebContentsUserData<ChromeTranslateClient> {
public:
- virtual ~ChromeTranslateClient();
+ ~ChromeTranslateClient() override;
// Gets the LanguageState associated with the page.
translate::LanguageState& GetLanguageState();
@@ -79,38 +79,35 @@ class ChromeTranslateClient
content::WebContents* GetWebContents();
// TranslateClient implementation.
- virtual translate::TranslateDriver* GetTranslateDriver() override;
- virtual PrefService* GetPrefs() override;
- virtual scoped_ptr<translate::TranslatePrefs> GetTranslatePrefs() override;
- virtual translate::TranslateAcceptLanguages* GetTranslateAcceptLanguages()
- override;
- virtual int GetInfobarIconID() const override;
- virtual scoped_ptr<infobars::InfoBar> CreateInfoBar(
+ translate::TranslateDriver* GetTranslateDriver() override;
+ PrefService* GetPrefs() override;
+ scoped_ptr<translate::TranslatePrefs> GetTranslatePrefs() override;
+ translate::TranslateAcceptLanguages* GetTranslateAcceptLanguages() override;
+ int GetInfobarIconID() const override;
+ scoped_ptr<infobars::InfoBar> CreateInfoBar(
scoped_ptr<translate::TranslateInfoBarDelegate> delegate) const override;
- virtual void ShowTranslateUI(translate::TranslateStep step,
- const std::string source_language,
- const std::string target_language,
- translate::TranslateErrors::Type error_type,
- bool triggered_from_menu) override;
- virtual bool IsTranslatableURL(const GURL& url) override;
- virtual void ShowReportLanguageDetectionErrorUI(
- const GURL& report_url) override;
+ void ShowTranslateUI(translate::TranslateStep step,
+ const std::string source_language,
+ const std::string target_language,
+ translate::TranslateErrors::Type error_type,
+ bool triggered_from_menu) override;
+ bool IsTranslatableURL(const GURL& url) override;
+ void ShowReportLanguageDetectionErrorUI(const GURL& report_url) override;
// ContentTranslateDriver::Observer implementation.
- virtual void OnLanguageDetermined(
+ void OnLanguageDetermined(
const translate::LanguageDetectionDetails& details) override;
- virtual void OnPageTranslated(
- const std::string& original_lang,
- const std::string& translated_lang,
- translate::TranslateErrors::Type error_type) override;
+ void OnPageTranslated(const std::string& original_lang,
+ const std::string& translated_lang,
+ translate::TranslateErrors::Type error_type) override;
private:
explicit ChromeTranslateClient(content::WebContents* web_contents);
friend class content::WebContentsUserData<ChromeTranslateClient>;
// content::WebContentsObserver implementation.
- virtual bool OnMessageReceived(const IPC::Message& message) override;
- virtual void WebContentsDestroyed() override;
+ bool OnMessageReceived(const IPC::Message& message) override;
+ void WebContentsDestroyed() override;
// Shows the translate bubble.
void ShowBubble(translate::TranslateStep step,
« no previous file with comments | « chrome/browser/thumbnails/thumbnail_tab_helper.h ('k') | chrome/browser/translate/static_cld_data_harness.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698