Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7143)

Unified Diff: chrome/browser/thumbnails/thumbnail_service_unittest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/thumbnails/thumbnail_service_unittest.cc
diff --git a/chrome/browser/thumbnails/thumbnail_service_unittest.cc b/chrome/browser/thumbnails/thumbnail_service_unittest.cc
index b72654d8a4e690916796b6862b4617774112c3f2..32f564c37a3a8b9050ace37b824873a55f2f528f 100644
--- a/chrome/browser/thumbnails/thumbnail_service_unittest.cc
+++ b/chrome/browser/thumbnails/thumbnail_service_unittest.cc
@@ -21,17 +21,12 @@ class MockTopSites : public history::TopSitesImpl {
}
// history::TopSitesImpl overrides.
- virtual bool IsNonForcedFull() override {
- return known_url_map_.size() >= capacity_;
- }
- virtual bool IsForcedFull() override {
- return false;
- }
- virtual bool IsKnownURL(const GURL& url) override {
+ bool IsNonForcedFull() override { return known_url_map_.size() >= capacity_; }
+ bool IsForcedFull() override { return false; }
+ bool IsKnownURL(const GURL& url) override {
return known_url_map_.find(url.spec()) != known_url_map_.end();
}
- virtual bool GetPageThumbnailScore(const GURL& url,
- ThumbnailScore* score) override {
+ bool GetPageThumbnailScore(const GURL& url, ThumbnailScore* score) override {
std::map<std::string, ThumbnailScore>::const_iterator iter =
known_url_map_.find(url.spec());
if (iter == known_url_map_.end()) {
@@ -48,7 +43,7 @@ class MockTopSites : public history::TopSitesImpl {
}
private:
- virtual ~MockTopSites() {}
+ ~MockTopSites() override {}
const size_t capacity_;
std::map<std::string, ThumbnailScore> known_url_map_;
@@ -62,9 +57,7 @@ class MockProfile : public TestingProfile {
MockProfile() : mock_top_sites_(new MockTopSites(this)) {
}
- virtual history::TopSites* GetTopSites() override {
- return mock_top_sites_.get();
- }
+ history::TopSites* GetTopSites() override { return mock_top_sites_.get(); }
void AddKnownURL(const GURL& url, const ThumbnailScore& score) {
mock_top_sites_->AddKnownURL(url, score);
« no previous file with comments | « chrome/browser/thumbnails/thumbnail_service_impl.h ('k') | chrome/browser/thumbnails/thumbnail_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698