chrome/browser/ssl/ssl_error_classification.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_error_classification.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ssl/ssl_client_certificate_selector_test.h ('k') | chrome/browser/status_icons/desktop_notification_balloon.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_error_classification.h

diff --git a/chrome/browser/ssl/ssl_error_classification.h b/chrome/browser/ssl/ssl_error_classification.h

index 44539d6d9be090f9468d1a816994e142bfb5565b..bdcd8bcbc2a184e9f86d02233513da035a9c97b3 100644

--- a/chrome/browser/ssl/ssl_error_classification.h

+++ b/chrome/browser/ssl/ssl_error_classification.h

@@ -31,7 +31,7 @@ class SSLErrorClassification : public content::NotificationObserver {

const GURL& url,

int cert_error,

const net::X509Certificate& cert);

- virtual ~SSLErrorClassification();

+ ~SSLErrorClassification() override;

// Returns true if the system time is in the past.

static bool IsUserClockInThePast(const base::Time& time_now);

@@ -126,10 +126,9 @@ class SSLErrorClassification : public content::NotificationObserver {

float CalculateScoreEnvironments() const;

// content::NotificationObserver:

- virtual void Observe(

- int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

content::WebContents* web_contents_;

// This stores the current time.