Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3069)

Unified Diff: chrome/browser/ssl/ssl_add_certificate.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc ('k') | chrome/browser/ssl/ssl_blocking_page.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_add_certificate.cc
diff --git a/chrome/browser/ssl/ssl_add_certificate.cc b/chrome/browser/ssl/ssl_add_certificate.cc
index 86f3c8ca8b042cd2652b478954f42cfd6fb4e1b3..bac7ee566de6b3fc614a1508ca87dffe5a0cfc52 100644
--- a/chrome/browser/ssl/ssl_add_certificate.cc
+++ b/chrome/browser/ssl/ssl_add_certificate.cc
@@ -43,35 +43,31 @@ class SSLAddCertificateInfoBarDelegate : public ConfirmInfoBarDelegate {
private:
explicit SSLAddCertificateInfoBarDelegate(net::X509Certificate* cert)
: cert_(cert) {}
- virtual ~SSLAddCertificateInfoBarDelegate() {}
+ ~SSLAddCertificateInfoBarDelegate() override {}
// ConfirmInfoBarDelegate implementation:
- virtual int GetIconID() const override {
+ int GetIconID() const override {
// TODO(davidben): Use a more appropriate icon.
return IDR_INFOBAR_SAVE_PASSWORD;
}
- virtual Type GetInfoBarType() const override {
- return PAGE_ACTION_TYPE;
- }
+ Type GetInfoBarType() const override { return PAGE_ACTION_TYPE; }
- virtual base::string16 GetMessageText() const override {
+ base::string16 GetMessageText() const override {
// TODO(evanm): GetDisplayName should return UTF-16.
return l10n_util::GetStringFUTF16(IDS_ADD_CERT_SUCCESS_INFOBAR_LABEL,
base::UTF8ToUTF16(
cert_->issuer().GetDisplayName()));
}
- virtual int GetButtons() const override {
- return BUTTON_OK;
- }
+ int GetButtons() const override { return BUTTON_OK; }
- virtual base::string16 GetButtonLabel(InfoBarButton button) const override {
+ base::string16 GetButtonLabel(InfoBarButton button) const override {
DCHECK_EQ(BUTTON_OK, button);
return l10n_util::GetStringUTF16(IDS_ADD_CERT_SUCCESS_INFOBAR_BUTTON);
}
- virtual bool Accept() override {
+ bool Accept() override {
WebContents* web_contents =
InfoBarService::WebContentsFromInfoBar(infobar());
ShowCertificateViewer(web_contents,
« no previous file with comments | « chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc ('k') | chrome/browser/ssl/ssl_blocking_page.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698