chrome/browser/services/gcm/push_messaging_service_impl.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/push_messaging_service_impl.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/services/gcm/push_messaging_permission_context_factory.h ('k') | chrome/browser/sessions/better_session_restore_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/services/gcm/push_messaging_service_impl.h

diff --git a/chrome/browser/services/gcm/push_messaging_service_impl.h b/chrome/browser/services/gcm/push_messaging_service_impl.h

index 0ef2e6dd9b2349dfa5c1f195a33b7700478e1086..b38f3779115e1ce5b168a807e6aa9984d4dee33e 100644

--- a/chrome/browser/services/gcm/push_messaging_service_impl.h

+++ b/chrome/browser/services/gcm/push_messaging_service_impl.h

@@ -34,22 +34,22 @@ class PushMessagingServiceImpl : public content::PushMessagingService,

PushMessagingServiceImpl(GCMProfileService* gcm_profile_service,

Profile* profile);

- virtual ~PushMessagingServiceImpl();

+ ~PushMessagingServiceImpl() override;

// GCMAppHandler implementation.

- virtual void ShutdownHandler() override;

- virtual void OnMessage(const std::string& app_id,

- const GCMClient::IncomingMessage& message) override;

- virtual void OnMessagesDeleted(const std::string& app_id) override;

- virtual void OnSendError(

+ void ShutdownHandler() override;

+ void OnMessage(const std::string& app_id,

+ const GCMClient::IncomingMessage& message) override;

+ void OnMessagesDeleted(const std::string& app_id) override;

+ void OnSendError(

const std::string& app_id,

const GCMClient::SendErrorDetails& send_error_details) override;

- virtual void OnSendAcknowledged(const std::string& app_id,

- const std::string& message_id) override;

- virtual bool CanHandle(const std::string& app_id) const override;

+ void OnSendAcknowledged(const std::string& app_id,

+ const std::string& message_id) override;

+ bool CanHandle(const std::string& app_id) const override;

// content::PushMessagingService implementation:

- virtual void Register(

+ void Register(

const GURL& origin,

int64 service_worker_registration_id,

const std::string& sender_id,