chrome/browser/search/suggestions/suggestions_source.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/suggestions/suggestions_source.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/search/suggestions/suggestions_service_factory.h ('k') | chrome/browser/search_engines/chrome_template_url_service_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search/suggestions/suggestions_source.h

diff --git a/chrome/browser/search/suggestions/suggestions_source.h b/chrome/browser/search/suggestions/suggestions_source.h

index a724abb7312322b415e9f252a56236e87540db04..eb31cb42c5eb6a9ee2da3f28ff80af7fb1632186 100644

--- a/chrome/browser/search/suggestions/suggestions_source.h

+++ b/chrome/browser/search/suggestions/suggestions_source.h

@@ -30,16 +30,18 @@ class SuggestionsSource : public content::URLDataSource {

explicit SuggestionsSource(Profile* profile);

// content::URLDataSource implementation.

- virtual std::string GetSource() const override;

- virtual void StartDataRequest(

- const std::string& path, int render_process_id, int render_frame_id,

+ std::string GetSource() const override;

+ void StartDataRequest(

+ const std::string& path,

+ int render_process_id,

+ int render_frame_id,

const content::URLDataSource::GotDataCallback& callback) override;

- virtual std::string GetMimeType(const std::string& path) const override;

- virtual base::MessageLoop* MessageLoopForRequestPath(

+ std::string GetMimeType(const std::string& path) const override;

+ base::MessageLoop* MessageLoopForRequestPath(

const std::string& path) const override;

private:

- virtual ~SuggestionsSource();

+ ~SuggestionsSource() override;

// Container for the state of a request.

struct RequestContext {