chrome/browser/renderer_host/chrome_extension_message_filter.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_extension_message_filter.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc ('k') | chrome/browser/renderer_host/chrome_render_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/chrome_extension_message_filter.h

diff --git a/chrome/browser/renderer_host/chrome_extension_message_filter.h b/chrome/browser/renderer_host/chrome_extension_message_filter.h

index 2ca9d25f1f9a482300fb0005d18cf40f53ff7f3b..5ae309b46770061450cb4e1697205b62343e99e3 100644

--- a/chrome/browser/renderer_host/chrome_extension_message_filter.h

+++ b/chrome/browser/renderer_host/chrome_extension_message_filter.h

@@ -35,17 +35,16 @@ class ChromeExtensionMessageFilter : public content::BrowserMessageFilter,

ChromeExtensionMessageFilter(int render_process_id, Profile* profile);

// content::BrowserMessageFilter methods:

- virtual bool OnMessageReceived(const IPC::Message& message) override;

- virtual void OverrideThreadForMessage(

- const IPC::Message& message,

- content::BrowserThread::ID* thread) override;

- virtual void OnDestruct() const override;

+ bool OnMessageReceived(const IPC::Message& message) override;

+ void OverrideThreadForMessage(const IPC::Message& message,

+ content::BrowserThread::ID* thread) override;

+ void OnDestruct() const override;

private:

friend class content::BrowserThread;

friend class base::DeleteHelper<ChromeExtensionMessageFilter>;

- virtual ~ChromeExtensionMessageFilter();

+ ~ChromeExtensionMessageFilter() override;

// TODO(jamescook): Move these functions into the extensions module. Ideally

// this would be in extensions::ExtensionMessageFilter but that will require

@@ -101,9 +100,9 @@ class ChromeExtensionMessageFilter : public content::BrowserMessageFilter,

const ExtensionHostMsg_APIActionOrEvent_Params& params);

// content::NotificationObserver implementation.

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

const int render_process_id_;