chrome/browser/predictors/resource_prefetch_predictor.cc - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/predictors/resource_prefetch_predictor.h ('k') | chrome/browser/predictors/resource_prefetch_predictor_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/predictors/resource_prefetch_predictor.cc

diff --git a/chrome/browser/predictors/resource_prefetch_predictor.cc b/chrome/browser/predictors/resource_prefetch_predictor.cc

index ea767daf69fe59792c6ebd121297aaacaf393aa4..878113d3faa552f34d35eb178acd072970c99778 100644

--- a/chrome/browser/predictors/resource_prefetch_predictor.cc

+++ b/chrome/browser/predictors/resource_prefetch_predictor.cc

@@ -117,20 +117,20 @@ class GetUrlVisitCountTask : public history::HistoryDBTask {

DCHECK(requests_.get());

}

- virtual bool RunOnDBThread(history::HistoryBackend* backend,

- history::HistoryDatabase* db) override {

+ bool RunOnDBThread(history::HistoryBackend* backend,

+ history::HistoryDatabase* db) override {

history::URLRow url_row;

if (db->GetRowForURL(navigation_id_.main_frame_url, &url_row))

visit_count_ = url_row.visit_count();

return true;

}

- virtual void DoneRunOnMainThread() override {

+ void DoneRunOnMainThread() override {

callback_.Run(visit_count_, navigation_id_, *requests_);

}

private:

- virtual ~GetUrlVisitCountTask() { }

+ ~GetUrlVisitCountTask() override {}

int visit_count_;

NavigationID navigation_id_;