chrome/browser/omaha_query_params/chrome_omaha_query_params_delegate.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/omaha_query_params/chrome_omaha_query_params_delegate.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc ('k') | chrome/browser/pepper_broker_infobar_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/omaha_query_params/chrome_omaha_query_params_delegate.h

diff --git a/chrome/browser/omaha_query_params/chrome_omaha_query_params_delegate.h b/chrome/browser/omaha_query_params/chrome_omaha_query_params_delegate.h

index 374ddbeb845c97ef3149dba569735cfb34cc8d1a..2f25c65a182bee202c504ba903d9a54030fec3b6 100644

--- a/chrome/browser/omaha_query_params/chrome_omaha_query_params_delegate.h

+++ b/chrome/browser/omaha_query_params/chrome_omaha_query_params_delegate.h

@@ -11,13 +11,13 @@ class ChromeOmahaQueryParamsDelegate

: public omaha_query_params::OmahaQueryParamsDelegate {

public:

ChromeOmahaQueryParamsDelegate();

- virtual ~ChromeOmahaQueryParamsDelegate();

+ ~ChromeOmahaQueryParamsDelegate() override;

// Gets the LazyInstance for ChromeOmahaQueryParamsDelegate.

static ChromeOmahaQueryParamsDelegate* GetInstance();

// omaha_query_params::OmahaQueryParamsDelegate:

- virtual std::string GetExtraParams() override;

+ std::string GetExtraParams() override;

// Returns the value we use for the "updaterchannel=" and "prodchannel="

// parameters. Possible return values include: "canary", "dev", "beta", and

« no previous file with comments | « chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc ('k') | chrome/browser/pepper_broker_infobar_delegate.h » ('j') | no next file with comments »