chrome/browser/metrics/field_trial_synchronizer.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/field_trial_synchronizer.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/extensions_metrics_provider_unittest.cc ('k') | chrome/browser/metrics/metrics_service_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/field_trial_synchronizer.h

diff --git a/chrome/browser/metrics/field_trial_synchronizer.h b/chrome/browser/metrics/field_trial_synchronizer.h

index b9d59b0bbef64ab36c93289af189127bf9040624..6c62d2772b9d7c1f72a026c9ca8b1ab4c54f6b7c 100644

--- a/chrome/browser/metrics/field_trial_synchronizer.h

+++ b/chrome/browser/metrics/field_trial_synchronizer.h

@@ -45,13 +45,12 @@ class FieldTrialSynchronizer

// is finalized. This method contacts all renderers (by calling

// NotifyAllRenderers) to create a FieldTrial that carries the randomly

// selected state from the browser process into all the renderer processes.

- virtual void OnFieldTrialGroupFinalized(

- const std::string& name,

- const std::string& group_name) override;

+ void OnFieldTrialGroupFinalized(const std::string& name,

+ const std::string& group_name) override;

private:

friend class base::RefCountedThreadSafe<FieldTrialSynchronizer>;

- virtual ~FieldTrialSynchronizer();

+ ~FieldTrialSynchronizer() override;

DISALLOW_COPY_AND_ASSIGN(FieldTrialSynchronizer);

};