chrome/browser/invalidation/gcm_invalidation_bridge_unittest.cc - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/invalidation/gcm_invalidation_bridge_unittest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/invalidation/fake_invalidation_service.h ('k') | chrome/browser/invalidation/profile_invalidation_provider_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/invalidation/gcm_invalidation_bridge_unittest.cc

diff --git a/chrome/browser/invalidation/gcm_invalidation_bridge_unittest.cc b/chrome/browser/invalidation/gcm_invalidation_bridge_unittest.cc

index 0aca581192ab3aedee5e1613b2873087b8d8dfec..8fae64fbd047f9150cf6aed0c07e2eb0c87cf73c 100644

--- a/chrome/browser/invalidation/gcm_invalidation_bridge_unittest.cc

+++ b/chrome/browser/invalidation/gcm_invalidation_bridge_unittest.cc

@@ -24,13 +24,12 @@ namespace {

class CustomFakeGCMDriver : public gcm::FakeGCMDriver {

public:

CustomFakeGCMDriver() {}

- virtual ~CustomFakeGCMDriver() {}

+ ~CustomFakeGCMDriver() override {}

protected:

// FakeGCMDriver override:

- virtual void RegisterImpl(

- const std::string& app_id,

- const std::vector<std::string>& sender_ids) override {

+ void RegisterImpl(const std::string& app_id,

+ const std::vector<std::string>& sender_ids) override {

base::MessageLoop::current()->PostTask(

FROM_HERE,

base::Bind(&CustomFakeGCMDriver::RegisterFinished,