chrome/browser/intranet_redirect_detector.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/intranet_redirect_detector.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/infobars/simple_alert_infobar_delegate.h ('k') | chrome/browser/invalidation/fake_invalidation_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/intranet_redirect_detector.h

diff --git a/chrome/browser/intranet_redirect_detector.h b/chrome/browser/intranet_redirect_detector.h

index 9325036efcb1d11fd3f0dd894f46c1648351dafc..58f23f1b16ab4537ed4af84f8d4b4e074a018d93 100644

--- a/chrome/browser/intranet_redirect_detector.h

+++ b/chrome/browser/intranet_redirect_detector.h

@@ -46,7 +46,7 @@ class IntranetRedirectDetector

// since there aren't useful public functions on this object for consumers to

// access anyway).

IntranetRedirectDetector();

- virtual ~IntranetRedirectDetector();

+ ~IntranetRedirectDetector() override;

// Returns the current redirect origin. This will be empty if no redirection

// is in place.

@@ -62,10 +62,10 @@ class IntranetRedirectDetector

void FinishSleep();

// net::URLFetcherDelegate

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

// NetworkChangeNotifier::IPAddressObserver

- virtual void OnIPAddressChanged() override;

+ void OnIPAddressChanged() override;

GURL redirect_origin_;

Fetchers fetchers_;

« no previous file with comments | « chrome/browser/infobars/simple_alert_infobar_delegate.h ('k') | chrome/browser/invalidation/fake_invalidation_service.h » ('j') | no next file with comments »