chrome/browser/importer/in_process_importer_bridge.cc - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/in_process_importer_bridge.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/importer/in_process_importer_bridge.cc

diff --git a/chrome/browser/importer/in_process_importer_bridge.cc b/chrome/browser/importer/in_process_importer_bridge.cc

index ed24891f048bca421a97f1a5809ce18f0c420b16..22cd5473da27ad85f7ecbd6f99d761cac6791655 100644

--- a/chrome/browser/importer/in_process_importer_bridge.cc

+++ b/chrome/browser/importer/in_process_importer_bridge.cc

@@ -83,11 +83,11 @@ namespace {

class FirefoxURLParameterFilter : public TemplateURLParser::ParameterFilter {

public:

FirefoxURLParameterFilter() {}

- virtual ~FirefoxURLParameterFilter() {}

+ ~FirefoxURLParameterFilter() override {}

// TemplateURLParser::ParameterFilter method.

- virtual bool KeepParameter(const std::string& key,

- const std::string& value) override {

+ bool KeepParameter(const std::string& key,

+ const std::string& value) override {

std::string low_value = base::StringToLowerASCII(value);

if (low_value.find("mozilla") != std::string::npos ||

low_value.find("firefox") != std::string::npos ||

« no previous file with comments | « chrome/browser/importer/in_process_importer_bridge.h ('k') | chrome/browser/importer/profile_writer_unittest.cc » ('j') | no next file with comments »