chrome/browser/importer/external_process_importer_host.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/external_process_importer_host.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/importer/external_process_importer_client.h ('k') | chrome/browser/importer/firefox_importer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/importer/external_process_importer_host.h

diff --git a/chrome/browser/importer/external_process_importer_host.h b/chrome/browser/importer/external_process_importer_host.h

index b1c01e3ee15d6fed8a358da140f6f9ef0e41470d..f9cf1c674b87cee09c612c386b73881d4cc0194e 100644

--- a/chrome/browser/importer/external_process_importer_host.h

+++ b/chrome/browser/importer/external_process_importer_host.h

@@ -71,7 +71,7 @@ class ExternalProcessImporterHost : public BaseBookmarkModelObserver {

private:

// ExternalProcessImporterHost deletes itself in OnImportEnded().

- virtual ~ExternalProcessImporterHost();

+ ~ExternalProcessImporterHost() override;

// Launches the utility process that starts the import task, unless bookmark

// or template model are not yet loaded. If load is not detected, this method

@@ -80,10 +80,9 @@ class ExternalProcessImporterHost : public BaseBookmarkModelObserver {

virtual void LaunchImportIfReady();

// BaseBookmarkModelObserver:

- virtual void BookmarkModelLoaded(BookmarkModel* model,

- bool ids_reassigned) override;

- virtual void BookmarkModelBeingDeleted(BookmarkModel* model) override;

- virtual void BookmarkModelChanged() override;

+ void BookmarkModelLoaded(BookmarkModel* model, bool ids_reassigned) override;

+ void BookmarkModelBeingDeleted(BookmarkModel* model) override;

+ void BookmarkModelChanged() override;

// Called when TemplateURLService has been loaded.

void OnTemplateURLServiceLoaded();