chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.h ('k') | chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h

diff --git a/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h b/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h

index 690e972ec0f68f585e89bc1a85a2c6d96d8104f9..72341494f68068bd3261cb4a0e4b595c216c7af0 100644

--- a/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h

+++ b/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h

@@ -17,14 +17,13 @@ class ChromeExtensionOptionsGuestDelegate

: public ExtensionOptionsGuestDelegate {

public:

explicit ChromeExtensionOptionsGuestDelegate(ExtensionOptionsGuest* guest);

- virtual ~ChromeExtensionOptionsGuestDelegate();

+ ~ChromeExtensionOptionsGuestDelegate() override;

- virtual void DidInitialize() override;

+ void DidInitialize() override;

- virtual bool HandleContextMenu(

- const content::ContextMenuParams& params) override;

+ bool HandleContextMenu(const content::ContextMenuParams& params) override;

- virtual content::WebContents* OpenURLInNewTab(

+ content::WebContents* OpenURLInNewTab(

const content::OpenURLParams& params) override;

private: