Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Unified Diff: chrome/browser/geolocation/geolocation_permission_context.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/geolocation/geolocation_permission_context.h
diff --git a/chrome/browser/geolocation/geolocation_permission_context.h b/chrome/browser/geolocation/geolocation_permission_context.h
index 6ca3d2162748ddae5da9d3d0b209dce68ba5d556..affa191d50075179eb766eda939bcf7546599440 100644
--- a/chrome/browser/geolocation/geolocation_permission_context.h
+++ b/chrome/browser/geolocation/geolocation_permission_context.h
@@ -19,26 +19,25 @@ class Profile;
class GeolocationPermissionContext : public PermissionContextBase {
public:
explicit GeolocationPermissionContext(Profile* profile);
- virtual ~GeolocationPermissionContext();
-
+ ~GeolocationPermissionContext() override;
// In addition to the base class flow the geolocation permission request
// checks that it is only code from valid iframes.
// It also adds special logic when called through an extension.
- virtual void RequestPermission(content::WebContents* web_contents,
- const PermissionRequestID& id,
- const GURL& requesting_frame_origin,
- bool user_gesture,
- const BrowserPermissionCallback& callback) override;
+ void RequestPermission(content::WebContents* web_contents,
+ const PermissionRequestID& id,
+ const GURL& requesting_frame_origin,
+ bool user_gesture,
+ const BrowserPermissionCallback& callback) override;
// Adds special logic when called through an extension.
- virtual void CancelPermissionRequest(content::WebContents* web_contents,
- const PermissionRequestID& id) override;
+ void CancelPermissionRequest(content::WebContents* web_contents,
+ const PermissionRequestID& id) override;
private:
- virtual void UpdateTabContext(const PermissionRequestID& id,
- const GURL& requesting_frame,
- bool allowed) override;
+ void UpdateTabContext(const PermissionRequestID& id,
+ const GURL& requesting_frame,
+ bool allowed) override;
// This must only be accessed from the UI thread.
GeolocationPermissionContextExtensions extensions_context_;

Powered by Google App Engine
This is Rietveld 408576698