chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/feedback/feedback_profile_observer.h ('k') | chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.h

diff --git a/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.h b/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.h

index 59111a7f47f1950fdbc75a60d521f025aed5854b..f533965b17cd4f171f9fe1539361c53c756064e0 100644

--- a/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.h

+++ b/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.h

@@ -13,10 +13,10 @@ namespace system_logs {

class ChromeInternalLogSource : public SystemLogsSource {

public:

ChromeInternalLogSource();

- virtual ~ChromeInternalLogSource();

+ ~ChromeInternalLogSource() override;

// SystemLogsSource override.

- virtual void Fetch(const SysLogsSourceCallback& request) override;

+ void Fetch(const SysLogsSourceCallback& request) override;

private:

void PopulateSyncLogs(SystemLogsResponse* response);