chrome/browser/favicon/chrome_favicon_client.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/chrome_favicon_client.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/favicon/chrome_favicon_client.h

diff --git a/chrome/browser/favicon/chrome_favicon_client.h b/chrome/browser/favicon/chrome_favicon_client.h

index 932cb7c1284e05a7a7a9d6cd2a2d4aa2a62256e0..9c64512ab22ceb35d50863762db4a6b3be2fceb7 100644

--- a/chrome/browser/favicon/chrome_favicon_client.h

+++ b/chrome/browser/favicon/chrome_favicon_client.h

@@ -17,11 +17,11 @@ class Profile;

class ChromeFaviconClient : public FaviconClient {

public:

explicit ChromeFaviconClient(Profile* profile);

- virtual ~ChromeFaviconClient();

+ ~ChromeFaviconClient() override;

// FaviconClient implementation:

- virtual FaviconService* GetFaviconService() override;

- virtual bool IsBookmarked(const GURL& url) override;

+ FaviconService* GetFaviconService() override;

+ bool IsBookmarked(const GURL& url) override;

private:

Profile* profile_;

« no previous file with comments | « chrome/browser/fast_shutdown_browsertest.cc ('k') | chrome/browser/favicon/chrome_favicon_client_factory.h » ('j') | no next file with comments »