chrome/browser/external_protocol/external_protocol_handler.cc - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_protocol/external_protocol_handler.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/external_extension_browsertest.cc ('k') | chrome/browser/external_protocol/external_protocol_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/external_protocol/external_protocol_handler.cc

diff --git a/chrome/browser/external_protocol/external_protocol_handler.cc b/chrome/browser/external_protocol/external_protocol_handler.cc

index 061f094d324c31261946710ea0c1c067c48571ba..e2503f687027370e7d1e098725d81aa91823ff66 100644

--- a/chrome/browser/external_protocol/external_protocol_handler.cc

+++ b/chrome/browser/external_protocol/external_protocol_handler.cc

@@ -101,7 +101,7 @@ class ExternalDefaultProtocolObserver

tab_contents_id_(tab_contents_id),

prompt_user_(prompt_user) {}

- virtual void SetDefaultWebClientUIState(

+ void SetDefaultWebClientUIState(

ShellIntegration::DefaultWebClientUIState state) override {

DCHECK(base::MessageLoopForUI::IsCurrent());

@@ -135,7 +135,7 @@ class ExternalDefaultProtocolObserver

escaped_url_, render_process_host_id_, tab_contents_id_, delegate_);

}

- virtual bool IsOwnedByWorker() override { return true; }

+ bool IsOwnedByWorker() override { return true; }

private:

ExternalProtocolHandler::Delegate* delegate_;