chrome/browser/custom_home_pages_table_model.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_home_pages_table_model.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/custom_handlers/register_protocol_handler_permission_request.h ('k') | chrome/browser/diagnostics/diagnostics_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_home_pages_table_model.h

diff --git a/chrome/browser/custom_home_pages_table_model.h b/chrome/browser/custom_home_pages_table_model.h

index 59a4652ab95888ba46c9343695ac7d7fea46d9b0..ca199979bb7c505b5e7a5c99c3d93af79b18aaf7 100644

--- a/chrome/browser/custom_home_pages_table_model.h

+++ b/chrome/browser/custom_home_pages_table_model.h

@@ -31,7 +31,7 @@ class TableModelObserver;

class CustomHomePagesTableModel : public ui::TableModel {

public:

explicit CustomHomePagesTableModel(Profile* profile);

- virtual ~CustomHomePagesTableModel();

+ ~CustomHomePagesTableModel() override;

// Sets the set of urls that this model contains.

void SetURLs(const std::vector<GURL>& urls);

@@ -55,10 +55,10 @@ class CustomHomePagesTableModel : public ui::TableModel {

std::vector<GURL> GetURLs();

// TableModel overrides:

- virtual int RowCount() override;

- virtual base::string16 GetText(int row, int column_id) override;

- virtual base::string16 GetTooltip(int row) override;

- virtual void SetObserver(ui::TableModelObserver* observer) override;

+ int RowCount() override;

+ base::string16 GetText(int row, int column_id) override;

+ base::string16 GetTooltip(int row) override;

+ void SetObserver(ui::TableModelObserver* observer) override;

private:

// Each item in the model is represented as an Entry. Entry stores the URL