chrome/browser/custom_handlers/protocol_handler_registry_factory.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_handlers/protocol_handler_registry_factory.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/custom_handlers/protocol_handler_registry.h ('k') | chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_handlers/protocol_handler_registry_factory.h

diff --git a/chrome/browser/custom_handlers/protocol_handler_registry_factory.h b/chrome/browser/custom_handlers/protocol_handler_registry_factory.h

index fbba519409e66d980c7ff6ede8f414338dfc1667..2002de38f92f11fcc64ee5ee38b7e1dfb3395018 100644

--- a/chrome/browser/custom_handlers/protocol_handler_registry_factory.h

+++ b/chrome/browser/custom_handlers/protocol_handler_registry_factory.h

@@ -29,19 +29,19 @@ class ProtocolHandlerRegistryFactory

protected:

// BrowserContextKeyedServiceFactory implementation.

- virtual bool ServiceIsCreatedWithBrowserContext() const override;

- virtual content::BrowserContext* GetBrowserContextToUse(

+ bool ServiceIsCreatedWithBrowserContext() const override;

+ content::BrowserContext* GetBrowserContextToUse(

content::BrowserContext* context) const override;

- virtual bool ServiceIsNULLWhileTesting() const override;

+ bool ServiceIsNULLWhileTesting() const override;

private:

friend struct DefaultSingletonTraits<ProtocolHandlerRegistryFactory>;

ProtocolHandlerRegistryFactory();

- virtual ~ProtocolHandlerRegistryFactory();

+ ~ProtocolHandlerRegistryFactory() override;

// BrowserContextKeyedServiceFactory implementation.

- virtual KeyedService* BuildServiceInstanceFor(

+ KeyedService* BuildServiceInstanceFor(

content::BrowserContext* profile) const override;

DISALLOW_COPY_AND_ASSIGN(ProtocolHandlerRegistryFactory);