Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: chrome/browser/content_settings/permission_bubble_request_impl.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/permission_bubble_request_impl.h
diff --git a/chrome/browser/content_settings/permission_bubble_request_impl.h b/chrome/browser/content_settings/permission_bubble_request_impl.h
index c8eece6094e384c7b1eb490b9be9d5cdedd13cd4..caf05b7cc92b1d3713f83a424c7308dc6a8783e4 100644
--- a/chrome/browser/content_settings/permission_bubble_request_impl.h
+++ b/chrome/browser/content_settings/permission_bubble_request_impl.h
@@ -31,23 +31,23 @@ class PermissionBubbleRequestImpl : public PermissionBubbleRequest {
const PermissionDecidedCallback permission_decided_callback,
const base::Closure delete_callback);
- virtual ~PermissionBubbleRequestImpl();
+ ~PermissionBubbleRequestImpl() override;
// PermissionBubbleRequest:
- virtual int GetIconID() const override;
- virtual base::string16 GetMessageText() const override;
- virtual base::string16 GetMessageTextFragment() const override;
- virtual bool HasUserGesture() const override;
+ int GetIconID() const override;
+ base::string16 GetMessageText() const override;
+ base::string16 GetMessageTextFragment() const override;
+ bool HasUserGesture() const override;
// TODO(miguelg) Change this method to GetOrigin()
- virtual GURL GetRequestingHostname() const override;
+ GURL GetRequestingHostname() const override;
// Remember to call RegisterActionTaken for these methods if you are
// overriding them.
- virtual void PermissionGranted() override;
- virtual void PermissionDenied() override;
- virtual void Cancelled() override;
- virtual void RequestFinished() override;
+ void PermissionGranted() override;
+ void PermissionDenied() override;
+ void Cancelled() override;
+ void RequestFinished() override;
protected:
void RegisterActionTaken() { action_taken_ = true; }

Powered by Google App Engine
This is Rietveld 408576698