Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6124)

Unified Diff: chrome/browser/content_settings/cookie_settings.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/cookie_settings.h
diff --git a/chrome/browser/content_settings/cookie_settings.h b/chrome/browser/content_settings/cookie_settings.h
index 0dde88460d9a0eeb02d19bb779959dfe2fc452f5..8476ad22ca725d3e416bc84bb9ad74eaaafbf16a 100644
--- a/chrome/browser/content_settings/cookie_settings.h
+++ b/chrome/browser/content_settings/cookie_settings.h
@@ -90,7 +90,7 @@ class CookieSettings : public RefcountedKeyedService {
// Detaches the |CookieSettings| from all |Profile|-related objects like
// |PrefService|. This methods needs to be called before destroying the
// |Profile|. Afterwards, only const methods can be called.
- virtual void ShutdownOnUIThread() override;
+ void ShutdownOnUIThread() override;
// A helper for applying third party cookie blocking rules.
ContentSetting GetCookieSetting(
@@ -114,19 +114,19 @@ class CookieSettings : public RefcountedKeyedService {
friend struct DefaultSingletonTraits<Factory>;
Factory();
- virtual ~Factory();
+ ~Factory() override;
// |BrowserContextKeyedBaseFactory| methods:
- virtual void RegisterProfilePrefs(
+ void RegisterProfilePrefs(
user_prefs::PrefRegistrySyncable* registry) override;
- virtual content::BrowserContext* GetBrowserContextToUse(
+ content::BrowserContext* GetBrowserContextToUse(
content::BrowserContext* context) const override;
- virtual scoped_refptr<RefcountedKeyedService> BuildServiceInstanceFor(
+ scoped_refptr<RefcountedKeyedService> BuildServiceInstanceFor(
content::BrowserContext* context) const override;
};
private:
- virtual ~CookieSettings();
+ ~CookieSettings() override;
void OnBlockThirdPartyCookiesChanged();

Powered by Google App Engine
This is Rietveld 408576698