chrome/browser/content_settings/content_settings_override_provider.cc - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_override_provider.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_override_provider.h ('k') | chrome/browser/content_settings/content_settings_policy_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_override_provider.cc

diff --git a/chrome/browser/content_settings/content_settings_override_provider.cc b/chrome/browser/content_settings/content_settings_override_provider.cc

index 24a546781b5ff0a94a50d3963a3bdcfac7679928..d0682853119080e87fc2674467d81c5132d051ab 100644

--- a/chrome/browser/content_settings/content_settings_override_provider.cc

+++ b/chrome/browser/content_settings/content_settings_override_provider.cc

@@ -28,9 +28,9 @@ class OverrideRuleIterator : public RuleIterator {

public:

explicit OverrideRuleIterator(bool is_allowed) : is_done_(is_allowed) {}

- virtual bool HasNext() const override { return !is_done_; }

+ bool HasNext() const override { return !is_done_; }

- virtual Rule Next() override {

+ Rule Next() override {

DCHECK(!is_done_);

is_done_ = true;

return Rule(ContentSettingsPattern::Wildcard(),