chrome/browser/command_updater_unittest.cc - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/command_updater_unittest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/profiles/profile_helper.h ('k') | chrome/browser/content_settings/chrome_content_settings_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/command_updater_unittest.cc

diff --git a/chrome/browser/command_updater_unittest.cc b/chrome/browser/command_updater_unittest.cc

index 969509c48807ecaee03a3b1f5262240893f40f22..9e94bf49f78ef188fc9f75e2a2df881f5266d035 100644

--- a/chrome/browser/command_updater_unittest.cc

+++ b/chrome/browser/command_updater_unittest.cc

@@ -11,8 +11,7 @@

class FakeCommandUpdaterDelegate : public CommandUpdaterDelegate {

public:

- virtual void ExecuteCommandWithDisposition(int id,

- WindowOpenDisposition) override {

+ void ExecuteCommandWithDisposition(int id, WindowOpenDisposition) override {

EXPECT_EQ(1, id);

}

};

@@ -21,7 +20,7 @@ class FakeCommandObserver : public CommandObserver {

public:

FakeCommandObserver() : enabled_(true) {}

- virtual void EnabledStateChangedForCommand(int id, bool enabled) override {

+ void EnabledStateChangedForCommand(int id, bool enabled) override {

enabled_ = enabled;

}