Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: chrome/browser/chromeos/login/signin/oauth2_login_verifier.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/signin/oauth2_login_verifier.h
diff --git a/chrome/browser/chromeos/login/signin/oauth2_login_verifier.h b/chrome/browser/chromeos/login/signin/oauth2_login_verifier.h
index ae6b97a7bde7767aa1daf59a88c66478533209fe..9a4fbb57bd3aa210d2b66974416dee5a5a9888f3 100644
--- a/chrome/browser/chromeos/login/signin/oauth2_login_verifier.h
+++ b/chrome/browser/chromeos/login/signin/oauth2_login_verifier.h
@@ -50,7 +50,7 @@ class OAuth2LoginVerifier : public base::SupportsWeakPtr<OAuth2LoginVerifier>,
net::URLRequestContextGetter* system_request_context,
net::URLRequestContextGetter* user_request_context,
const std::string& oauthlogin_access_token);
- virtual ~OAuth2LoginVerifier();
+ ~OAuth2LoginVerifier() override;
// Initiates verification of GAIA cookies in |profile|'s cookie jar.
void VerifyUserCookies(Profile* profile);
@@ -66,22 +66,19 @@ class OAuth2LoginVerifier : public base::SupportsWeakPtr<OAuth2LoginVerifier>,
RESTORE_FROM_OAUTH2_REFRESH_TOKEN = 2,
};
// GaiaAuthConsumer overrides.
- virtual void OnUberAuthTokenSuccess(const std::string& token) override;
- virtual void OnUberAuthTokenFailure(
- const GoogleServiceAuthError& error) override;
- virtual void OnMergeSessionSuccess(const std::string& data) override;
- virtual void OnMergeSessionFailure(
- const GoogleServiceAuthError& error) override;
- virtual void OnListAccountsSuccess(const std::string& data) override;
- virtual void OnListAccountsFailure(
- const GoogleServiceAuthError& error) override;
+ void OnUberAuthTokenSuccess(const std::string& token) override;
+ void OnUberAuthTokenFailure(const GoogleServiceAuthError& error) override;
+ void OnMergeSessionSuccess(const std::string& data) override;
+ void OnMergeSessionFailure(const GoogleServiceAuthError& error) override;
+ void OnListAccountsSuccess(const std::string& data) override;
+ void OnListAccountsFailure(const GoogleServiceAuthError& error) override;
// OAuth2TokenService::Consumer overrides.
- virtual void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
- const std::string& access_token,
- const base::Time& expiration_time) override;
- virtual void OnGetTokenFailure(const OAuth2TokenService::Request* request,
- const GoogleServiceAuthError& error) override;
+ void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
+ const std::string& access_token,
+ const base::Time& expiration_time) override;
+ void OnGetTokenFailure(const OAuth2TokenService::Request* request,
+ const GoogleServiceAuthError& error) override;
// Starts fetching OAuth1 access token for OAuthLogin call.
void StartFetchingOAuthLoginAccessToken(Profile* profile);

Powered by Google App Engine
This is Rietveld 408576698