Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5145)

Unified Diff: chrome/browser/chrome_browser_main.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main.h
diff --git a/chrome/browser/chrome_browser_main.h b/chrome/browser/chrome_browser_main.h
index 2f16143511ffac5af08ea84927f16a63858b41b0..65cbaa378ad7ad5f601582859a2d3cd3eb1d1ec8 100644
--- a/chrome/browser/chrome_browser_main.h
+++ b/chrome/browser/chrome_browser_main.h
@@ -47,7 +47,7 @@ class TrackingSynchronizer;
class ChromeBrowserMainParts : public content::BrowserMainParts {
public:
- virtual ~ChromeBrowserMainParts();
+ ~ChromeBrowserMainParts() override;
// Add additional ChromeBrowserMainExtraParts.
virtual void AddParts(ChromeBrowserMainExtraParts* parts);
@@ -60,16 +60,16 @@ class ChromeBrowserMainParts : public content::BrowserMainParts {
// These are called in-order by content::BrowserMainLoop.
// Each stage calls the same stages in any ChromeBrowserMainExtraParts added
// with AddParts() from ChromeContentBrowserClient::CreateBrowserMainParts.
- virtual void PreEarlyInitialization() override;
- virtual void PostEarlyInitialization() override;
- virtual void ToolkitInitialized() override;
- virtual void PreMainMessageLoopStart() override;
- virtual void PostMainMessageLoopStart() override;
- virtual int PreCreateThreads() override;
- virtual void PreMainMessageLoopRun() override;
- virtual bool MainMessageLoopRun(int* result_code) override;
- virtual void PostMainMessageLoopRun() override;
- virtual void PostDestroyThreads() override;
+ void PreEarlyInitialization() override;
+ void PostEarlyInitialization() override;
+ void ToolkitInitialized() override;
+ void PreMainMessageLoopStart() override;
+ void PostMainMessageLoopStart() override;
+ int PreCreateThreads() override;
+ void PreMainMessageLoopRun() override;
+ bool MainMessageLoopRun(int* result_code) override;
+ void PostMainMessageLoopRun() override;
+ void PostDestroyThreads() override;
// Additional stages for ChromeBrowserMainExtraParts. These stages are called
// in order from PreMainMessageLoopRun(). See implementation for details.
« no previous file with comments | « chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc ('k') | chrome/browser/chrome_browser_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698