chrome/browser/captive_portal/captive_portal_service.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/captive_portal/captive_portal_service.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/captive_portal/captive_portal_browsertest.cc ('k') | chrome/browser/captive_portal/captive_portal_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/captive_portal/captive_portal_service.h

diff --git a/chrome/browser/captive_portal/captive_portal_service.h b/chrome/browser/captive_portal/captive_portal_service.h

index 8131f62b7aecd1e1306b9ec5b812c98ff53b9fab..66e6d1b4182049e14af547361a2e04522fe8148f 100644

--- a/chrome/browser/captive_portal/captive_portal_service.h

+++ b/chrome/browser/captive_portal/captive_portal_service.h

@@ -43,7 +43,7 @@ class CaptivePortalService : public KeyedService, public base::NonThreadSafe {

};

explicit CaptivePortalService(Profile* profile);

- virtual ~CaptivePortalService();

+ ~CaptivePortalService() override;

// Triggers a check for a captive portal. If there's already a check in

// progress, does nothing. Throttles the rate at which requests are sent.

@@ -114,7 +114,7 @@ class CaptivePortalService : public KeyedService, public base::NonThreadSafe {

const captive_portal::CaptivePortalDetector::Results& results);

// KeyedService:

- virtual void Shutdown() override;

+ void Shutdown() override;

// Called when a captive portal check completes. Passes the result to all

// observers.