Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: chrome/browser/browser_encoding_browsertest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_encoding_browsertest.cc
diff --git a/chrome/browser/browser_encoding_browsertest.cc b/chrome/browser/browser_encoding_browsertest.cc
index d80694db24a4377cd3603f8c2fe8c9a25e38a78c..b26d08f0c9b31b922f1b13c64aba0d594c964cdc 100644
--- a/chrome/browser/browser_encoding_browsertest.cc
+++ b/chrome/browser/browser_encoding_browsertest.cc
@@ -81,17 +81,17 @@ class SavePackageFinishedObserver : public content::DownloadManager::Observer {
download_manager_->AddObserver(this);
}
- virtual ~SavePackageFinishedObserver() {
+ ~SavePackageFinishedObserver() override {
if (download_manager_)
download_manager_->RemoveObserver(this);
}
// DownloadManager::Observer:
- virtual void OnSavePackageSuccessfullyFinished(
- content::DownloadManager* manager, content::DownloadItem* item) override {
+ void OnSavePackageSuccessfullyFinished(content::DownloadManager* manager,
+ content::DownloadItem* item) override {
callback_.Run();
}
- virtual void ManagerGoingDown(content::DownloadManager* manager) override {
+ void ManagerGoingDown(content::DownloadManager* manager) override {
download_manager_->RemoveObserver(this);
download_manager_ = NULL;
}
@@ -142,7 +142,7 @@ class BrowserEncodingTest
EXPECT_TRUE(base::ContentsEqual(full_file_name, expected_file_name));
}
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
save_dir_ = temp_dir_.path();
temp_sub_resource_dir_ = save_dir_.AppendASCII("sub_resource_files");
« no previous file with comments | « chrome/browser/bookmarks/chrome_bookmark_client_factory.h ('k') | chrome/browser/browser_keyevents_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698