Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: chrome/browser/bookmarks/chrome_bookmark_client.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/chrome_bookmark_client.h
diff --git a/chrome/browser/bookmarks/chrome_bookmark_client.h b/chrome/browser/bookmarks/chrome_bookmark_client.h
index f6e4d2d3646c3def7a54da110ec5d59c327142d4..8d3abe7417630f982d68cbf06d59488a91c11463 100644
--- a/chrome/browser/bookmarks/chrome_bookmark_client.h
+++ b/chrome/browser/bookmarks/chrome_bookmark_client.h
@@ -25,12 +25,12 @@ class ChromeBookmarkClient : public bookmarks::BookmarkClient,
public BaseBookmarkModelObserver {
public:
explicit ChromeBookmarkClient(Profile* profile);
- virtual ~ChromeBookmarkClient();
+ ~ChromeBookmarkClient() override;
void Init(BookmarkModel* model);
// KeyedService:
- virtual void Shutdown() override;
+ void Shutdown() override;
// Returns the managed_node.
const BookmarkNode* managed_node() { return managed_node_; }
@@ -43,41 +43,37 @@ class ChromeBookmarkClient : public bookmarks::BookmarkClient,
const std::vector<const BookmarkNode*>& list);
// bookmarks::BookmarkClient:
- virtual bool PreferTouchIcon() override;
- virtual base::CancelableTaskTracker::TaskId GetFaviconImageForPageURL(
+ bool PreferTouchIcon() override;
+ base::CancelableTaskTracker::TaskId GetFaviconImageForPageURL(
const GURL& page_url,
favicon_base::IconType type,
const favicon_base::FaviconImageCallback& callback,
base::CancelableTaskTracker* tracker) override;
- virtual bool SupportsTypedCountForNodes() override;
- virtual void GetTypedCountForNodes(
+ bool SupportsTypedCountForNodes() override;
+ void GetTypedCountForNodes(
const NodeSet& nodes,
NodeTypedCountPairs* node_typed_count_pairs) override;
- virtual bool IsPermanentNodeVisible(
- const BookmarkPermanentNode* node) override;
- virtual void RecordAction(const base::UserMetricsAction& action) override;
- virtual bookmarks::LoadExtraCallback GetLoadExtraNodesCallback() override;
- virtual bool CanSetPermanentNodeTitle(
- const BookmarkNode* permanent_node) override;
- virtual bool CanSyncNode(const BookmarkNode* node) override;
- virtual bool CanBeEditedByUser(const BookmarkNode* node) override;
+ bool IsPermanentNodeVisible(const BookmarkPermanentNode* node) override;
+ void RecordAction(const base::UserMetricsAction& action) override;
+ bookmarks::LoadExtraCallback GetLoadExtraNodesCallback() override;
+ bool CanSetPermanentNodeTitle(const BookmarkNode* permanent_node) override;
+ bool CanSyncNode(const BookmarkNode* node) override;
+ bool CanBeEditedByUser(const BookmarkNode* node) override;
private:
friend class HistoryServiceFactory;
void SetHistoryService(HistoryService* history_service);
// BaseBookmarkModelObserver:
- virtual void BookmarkModelChanged() override;
- virtual void BookmarkNodeRemoved(BookmarkModel* model,
- const BookmarkNode* parent,
- int old_index,
- const BookmarkNode* node,
+ void BookmarkModelChanged() override;
+ void BookmarkNodeRemoved(BookmarkModel* model,
+ const BookmarkNode* parent,
+ int old_index,
+ const BookmarkNode* node,
+ const std::set<GURL>& removed_urls) override;
+ void BookmarkAllUserNodesRemoved(BookmarkModel* model,
const std::set<GURL>& removed_urls) override;
- virtual void BookmarkAllUserNodesRemoved(
- BookmarkModel* model,
- const std::set<GURL>& removed_urls) override;
- virtual void BookmarkModelLoaded(BookmarkModel* model,
- bool ids_reassigned) override;
+ void BookmarkModelLoaded(BookmarkModel* model, bool ids_reassigned) override;
// Helper for GetLoadExtraNodesCallback().
static bookmarks::BookmarkPermanentNodeList LoadExtraNodes(
« no previous file with comments | « chrome/browser/bookmarks/bookmark_model_factory.h ('k') | chrome/browser/bookmarks/chrome_bookmark_client_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698