chrome/browser/bookmarks/bookmark_html_writer_unittest.cc - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

diff --git a/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc b/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

index 9c473e5808c1ec224f161a68c90012be3c8a9502..cc9da03266e2dc8343c612071fe88cdba8cc271d 100644

--- a/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

+++ b/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

@@ -130,9 +130,7 @@ class BookmarksObserver : public BookmarksExportObserver {

DCHECK(loop);

}

- virtual void OnExportFinished() override {

- loop_->Quit();

- }

+ void OnExportFinished() override { loop_->Quit(); }

private:

base::RunLoop* loop_;

« no previous file with comments | « chrome/browser/bookmarks/bookmark_html_writer.h ('k') | chrome/browser/bookmarks/bookmark_model_factory.h » ('j') | no next file with comments »