Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc
diff --git a/chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc b/chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc
index 2767455e2bb36171785e3184f8cda0565bc28dca..7d395aaa54a470e5fc079e34fcf02d315bd7dbb9 100644
--- a/chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc
+++ b/chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc
@@ -20,10 +20,10 @@ class TestNotificationInterface {
class TestObserver : public BitmapFetcherService::Observer {
public:
explicit TestObserver(TestNotificationInterface* target) : target_(target) {}
- virtual ~TestObserver() { target_->OnRequestFinished(); }
+ ~TestObserver() override { target_->OnRequestFinished(); }
- virtual void OnImageChanged(BitmapFetcherService::RequestId request_id,
- const SkBitmap& answers_image) override {
+ void OnImageChanged(BitmapFetcherService::RequestId request_id,
+ const SkBitmap& answers_image) override {
target_->OnImageChanged();
}
@@ -34,11 +34,11 @@ class TestService : public BitmapFetcherService {
public:
explicit TestService(content::BrowserContext* context)
: BitmapFetcherService(context) {}
- virtual ~TestService() {}
+ ~TestService() override {}
// Create a fetcher, but don't start downloading. That allows side-stepping
// the decode step, which requires a utility process.
- virtual chrome::BitmapFetcher* CreateFetcher(const GURL& url) override {
+ chrome::BitmapFetcher* CreateFetcher(const GURL& url) override {
return new chrome::BitmapFetcher(url, this);
}
};
@@ -64,9 +64,9 @@ class BitmapFetcherServiceTest : public testing::Test,
}
size_t cache_size() { return service_->cache_.size(); }
- virtual void OnImageChanged() override { imagesChanged_++; }
+ void OnImageChanged() override { imagesChanged_++; }
- virtual void OnRequestFinished() override { requestsFinished_++; }
+ void OnRequestFinished() override { requestsFinished_++; }
// Simulate finishing a URL fetch and decode for the given fetcher.
void CompleteFetch(const GURL& url) {
« no previous file with comments | « chrome/browser/bitmap_fetcher/bitmap_fetcher_service_factory.h ('k') | chrome/browser/bookmarks/bookmark_html_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698