chrome/browser/bitmap_fetcher/bitmap_fetcher_service.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bitmap_fetcher/bitmap_fetcher_service.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/bitmap_fetcher/bitmap_fetcher_browsertest.cc ('k') | chrome/browser/bitmap_fetcher/bitmap_fetcher_service_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bitmap_fetcher/bitmap_fetcher_service.h

diff --git a/chrome/browser/bitmap_fetcher/bitmap_fetcher_service.h b/chrome/browser/bitmap_fetcher/bitmap_fetcher_service.h

index cd80c2168b4618bf00d2edbd5e1a2eda8b7132d5..3d98dd8bb63aea67f5ca1ede57b68f8e9398ded7 100644

--- a/chrome/browser/bitmap_fetcher/bitmap_fetcher_service.h

+++ b/chrome/browser/bitmap_fetcher/bitmap_fetcher_service.h

@@ -42,7 +42,7 @@ class BitmapFetcherService : public KeyedService,

};

explicit BitmapFetcherService(content::BrowserContext* context);

- virtual ~BitmapFetcherService();

+ ~BitmapFetcherService() override;

// Cancels a request, if it is still in-flight.

void CancelRequest(RequestId requestId);

@@ -81,7 +81,7 @@ class BitmapFetcherService : public KeyedService,

void RemoveFetcher(const chrome::BitmapFetcher* fetcher);

// BitmapFetcherDelegate implementation.

- virtual void OnFetchComplete(const GURL url, const SkBitmap* bitmap) override;

+ void OnFetchComplete(const GURL url, const SkBitmap* bitmap) override;

// Currently active image fetchers.

BitmapFetchers active_fetchers_;