Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1893)

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_contents_service.cc
diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc
index b0c954fc77b50e5ae0acab1d08c57b4b3b4e56c3..016e429db82292831eda8e22c5d1e26f062e772f 100644
--- a/chrome/browser/background/background_contents_service.cc
+++ b/chrome/browser/background/background_contents_service.cc
@@ -104,13 +104,13 @@ class CrashNotificationDelegate : public NotificationDelegate {
extension_id_(extension->id()) {
}
- virtual void Display() override {}
+ void Display() override {}
- virtual void Error() override {}
+ void Error() override {}
- virtual void Close(bool by_user) override {}
+ void Close(bool by_user) override {}
- virtual void Click() override {
+ void Click() override {
// http://crbug.com/247790 involves a crash notification balloon being
// clicked while the extension isn't in the TERMINATED state. In that case,
// any of the "reload" methods called below can unload the extension, which
@@ -141,14 +141,14 @@ class CrashNotificationDelegate : public NotificationDelegate {
ScheduleCloseBalloon(copied_extension_id, profile_);
}
- virtual bool HasClickedListener() override { return true; }
+ bool HasClickedListener() override { return true; }
- virtual std::string id() const override {
+ std::string id() const override {
return kNotificationPrefix + extension_id_;
}
private:
- virtual ~CrashNotificationDelegate() {}
+ ~CrashNotificationDelegate() override {}
Profile* profile_;
bool is_hosted_app_;

Powered by Google App Engine
This is Rietveld 408576698