Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: chrome/browser/autofill/autofill_browsertest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_browsertest.cc
diff --git a/chrome/browser/autofill/autofill_browsertest.cc b/chrome/browser/autofill/autofill_browsertest.cc
index 9a19fc3211358b060b357acaef58ec08154afdf5..eb385e97c9520f678d4ee9e81fee4e503f0cbd68 100644
--- a/chrome/browser/autofill/autofill_browsertest.cc
+++ b/chrome/browser/autofill/autofill_browsertest.cc
@@ -67,7 +67,7 @@ class WindowedPersonalDataManagerObserver
infobar_service_->AddObserver(this);
}
- virtual ~WindowedPersonalDataManagerObserver() {
+ ~WindowedPersonalDataManagerObserver() override {
infobar_service_->RemoveObserver(this);
if (infobar_service_->infobar_count() > 0) {
@@ -85,7 +85,7 @@ class WindowedPersonalDataManagerObserver
}
// PersonalDataManagerObserver:
- virtual void OnPersonalDataChanged() override {
+ void OnPersonalDataChanged() override {
if (has_run_message_loop_) {
base::MessageLoopForUI::current()->Quit();
has_run_message_loop_ = false;
@@ -93,12 +93,10 @@ class WindowedPersonalDataManagerObserver
alerted_ = true;
}
- virtual void OnInsufficientFormData() override {
- OnPersonalDataChanged();
- }
+ void OnInsufficientFormData() override { OnPersonalDataChanged(); }
// infobars::InfoBarManager::Observer:
- virtual void OnInfoBarAdded(infobars::InfoBar* infobar) override {
+ void OnInfoBarAdded(infobars::InfoBar* infobar) override {
ConfirmInfoBarDelegate* infobar_delegate =
infobar_service_->infobar_at(0)->delegate()->AsConfirmInfoBarDelegate();
ASSERT_TRUE(infobar_delegate);
@@ -116,12 +114,12 @@ class AutofillTest : public InProcessBrowserTest {
protected:
AutofillTest() {}
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
// Don't want Keychain coming up on Mac.
test::DisableSystemServices(browser()->profile()->GetPrefs());
}
- virtual void TearDownOnMainThread() override {
+ void TearDownOnMainThread() override {
// Make sure to close any showing popups prior to tearing down the UI.
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
« no previous file with comments | « chrome/browser/autocomplete/zero_suggest_provider_unittest.cc ('k') | chrome/browser/autofill/autofill_cc_infobar_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698