chrome/browser/autocomplete/search_provider_unittest.cc - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/search_provider_unittest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/keyword_extensions_delegate_impl_unittest.cc ('k') | chrome/browser/autocomplete/shortcuts_backend.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/search_provider_unittest.cc

diff --git a/chrome/browser/autocomplete/search_provider_unittest.cc b/chrome/browser/autocomplete/search_provider_unittest.cc

index cdebf964509c0c37106dda7d56872244979141ae..5e9317011497b379ece5f2275c040865cf92dcfe 100644

--- a/chrome/browser/autocomplete/search_provider_unittest.cc

+++ b/chrome/browser/autocomplete/search_provider_unittest.cc

@@ -75,10 +75,10 @@ class SearchProviderForTest : public SearchProvider {

bool is_success() { return is_success_; };

protected:

- virtual ~SearchProviderForTest();

+ ~SearchProviderForTest() override;

private:

- virtual void RecordDeletionResult(bool success) override;

+ void RecordDeletionResult(bool success) override;

bool is_success_;

DISALLOW_COPY_AND_ASSIGN(SearchProviderForTest);

};

@@ -185,7 +185,7 @@ class SearchProviderTest : public testing::Test,

// AutocompleteProviderListener:

// If we're waiting for the provider to finish, this exits the message loop.

- virtual void OnProviderUpdate(bool updated_matches) override;

+ void OnProviderUpdate(bool updated_matches) override;

// Runs a nested message loop until provider_ is done. The message loop is

// exited by way of OnProviderUpdate.