Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/app_controller_mac.mm
diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
index 3171f02dd56b2eb011f84d55ee15668dce828d88..434e3e72ba261b284c2b3360666dd258e6be8b6e 100644
--- a/chrome/browser/app_controller_mac.mm
+++ b/chrome/browser/app_controller_mac.mm
@@ -236,7 +236,7 @@ class AppControllerProfileObserver : public ProfileInfoCacheObserver {
profile_manager_->GetProfileInfoCache().AddObserver(this);
}
- virtual ~AppControllerProfileObserver() {
+ ~AppControllerProfileObserver() override {
DCHECK(profile_manager_);
profile_manager_->GetProfileInfoCache().RemoveObserver(this);
}
@@ -244,29 +244,21 @@ class AppControllerProfileObserver : public ProfileInfoCacheObserver {
private:
// ProfileInfoCacheObserver implementation:
- virtual void OnProfileAdded(const base::FilePath& profile_path) override {
- }
+ void OnProfileAdded(const base::FilePath& profile_path) override {}
- virtual void OnProfileWasRemoved(
- const base::FilePath& profile_path,
- const base::string16& profile_name) override {
+ void OnProfileWasRemoved(const base::FilePath& profile_path,
+ const base::string16& profile_name) override {
// When a profile is deleted we need to notify the AppController,
// so it can correctly update its pointer to the last used profile.
[app_controller_ profileWasRemoved:profile_path];
}
- virtual void OnProfileWillBeRemoved(
- const base::FilePath& profile_path) override {
- }
+ void OnProfileWillBeRemoved(const base::FilePath& profile_path) override {}
- virtual void OnProfileNameChanged(
- const base::FilePath& profile_path,
- const base::string16& old_profile_name) override {
- }
+ void OnProfileNameChanged(const base::FilePath& profile_path,
+ const base::string16& old_profile_name) override {}
- virtual void OnProfileAvatarChanged(
- const base::FilePath& profile_path) override {
- }
+ void OnProfileAvatarChanged(const base::FilePath& profile_path) override {}
ProfileManager* profile_manager_;
« no previous file with comments | « chrome/browser/accessibility/accessibility_extension_api.h ('k') | chrome/browser/app_controller_mac_browsertest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698