chrome/browser/spellchecker/spellcheck_factory.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/spellchecker/spellcheck_factory.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc ('k') | chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_FACTORY_H_	5 #ifndef CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_FACTORY_H_

6 #define CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_FACTORY_H_	6 #define CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_FACTORY_H_

7	7

8 #include "base/basictypes.h"	8 #include "base/basictypes.h"

9 #include "base/gtest_prod_util.h"	9 #include "base/gtest_prod_util.h"

10 #include "base/memory/singleton.h"	10 #include "base/memory/singleton.h"

(...skipping 11 matching lines...) Expand all Loading...
22 static SpellcheckService* GetForContext(content::BrowserContext* context);	22 static SpellcheckService* GetForContext(content::BrowserContext* context);

23	23

24 static SpellcheckService* GetForRenderProcessId(int render_process_id);	24 static SpellcheckService* GetForRenderProcessId(int render_process_id);

25	25

26 static SpellcheckServiceFactory* GetInstance();	26 static SpellcheckServiceFactory* GetInstance();

27	27

28 private:	28 private:

29 friend struct DefaultSingletonTraits<SpellcheckServiceFactory>;	29 friend struct DefaultSingletonTraits<SpellcheckServiceFactory>;

30	30

31 SpellcheckServiceFactory();	31 SpellcheckServiceFactory();

32 virtual ~SpellcheckServiceFactory();	32 ~SpellcheckServiceFactory() override;

33	33

34 // BrowserContextKeyedServiceFactory:	34 // BrowserContextKeyedServiceFactory:

35 virtual KeyedService* BuildServiceInstanceFor(	35 KeyedService* BuildServiceInstanceFor(

36 content::BrowserContext* context) const override;	36 content::BrowserContext* context) const override;

37 virtual void RegisterProfilePrefs(	37 void RegisterProfilePrefs(

38 user_prefs::PrefRegistrySyncable* registry) override;	38 user_prefs::PrefRegistrySyncable* registry) override;

39 virtual content::BrowserContext* GetBrowserContextToUse(	39 content::BrowserContext* GetBrowserContextToUse(

40 content::BrowserContext* context) const override;	40 content::BrowserContext* context) const override;

41 virtual bool ServiceIsNULLWhileTesting() const override;	41 bool ServiceIsNULLWhileTesting() const override;

42	42

43 FRIEND_TEST_ALL_PREFIXES(SpellcheckServiceBrowserTest, DeleteCorruptedBDICT);	43 FRIEND_TEST_ALL_PREFIXES(SpellcheckServiceBrowserTest, DeleteCorruptedBDICT);

44	44

45 DISALLOW_COPY_AND_ASSIGN(SpellcheckServiceFactory);	45 DISALLOW_COPY_AND_ASSIGN(SpellcheckServiceFactory);

46 };	46 };

47	47

48 #endif // CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_FACTORY_H_	48 #endif // CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_FACTORY_H_

OLD	NEW