chrome/browser/sessions/session_service_factory.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/sessions/session_service_factory.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/sessions/session_service.h ('k') | chrome/browser/sessions/session_service_unittest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_SESSIONS_SESSION_SERVICE_FACTORY_H_	5 #ifndef CHROME_BROWSER_SESSIONS_SESSION_SERVICE_FACTORY_H_

6 #define CHROME_BROWSER_SESSIONS_SESSION_SERVICE_FACTORY_H_	6 #define CHROME_BROWSER_SESSIONS_SESSION_SERVICE_FACTORY_H_

7	7

8 #include "base/memory/singleton.h"	8 #include "base/memory/singleton.h"

9 #include "chrome/browser/profiles/profile.h"	9 #include "chrome/browser/profiles/profile.h"

10 #include "chrome/browser/sessions/session_service.h"	10 #include "chrome/browser/sessions/session_service.h"

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 #endif	52 #endif

53	53

54 static SessionServiceFactory* GetInstance();	54 static SessionServiceFactory* GetInstance();

55	55

56 private:	56 private:

57 friend struct DefaultSingletonTraits<SessionServiceFactory>;	57 friend struct DefaultSingletonTraits<SessionServiceFactory>;

58 FRIEND_TEST_ALL_PREFIXES(SessionCrashedInfoBarDelegateUnitTest,	58 FRIEND_TEST_ALL_PREFIXES(SessionCrashedInfoBarDelegateUnitTest,

59 DetachingTabWithCrashedInfoBar);	59 DetachingTabWithCrashedInfoBar);

60	60

61 SessionServiceFactory();	61 SessionServiceFactory();

62 virtual ~SessionServiceFactory();	62 ~SessionServiceFactory() override;

63	63

64 // BrowserContextKeyedServiceFactory:	64 // BrowserContextKeyedServiceFactory:

65 virtual KeyedService* BuildServiceInstanceFor(	65 KeyedService* BuildServiceInstanceFor(

66 content::BrowserContext* profile) const override;	66 content::BrowserContext* profile) const override;

67 virtual bool ServiceIsCreatedWithBrowserContext() const override;	67 bool ServiceIsCreatedWithBrowserContext() const override;

68 virtual bool ServiceIsNULLWhileTesting() const override;	68 bool ServiceIsNULLWhileTesting() const override;

69 };	69 };

70	70

71 #endif // CHROME_BROWSER_SESSIONS_SESSION_SERVICE_FACTORY_H_	71 #endif // CHROME_BROWSER_SESSIONS_SESSION_SERVICE_FACTORY_H_

OLD	NEW