Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/search/suggestions/image_fetcher_impl.h" 5 #include "chrome/browser/search/suggestions/image_fetcher_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
(...skipping 16 matching lines...) Expand all
27 const char kInvalidImagePath[] = "files/DOESNOTEXIST"; 27 const char kInvalidImagePath[] = "files/DOESNOTEXIST";
28 28
29 const base::FilePath::CharType kDocRoot[] = 29 const base::FilePath::CharType kDocRoot[] =
30 FILE_PATH_LITERAL("chrome/test/data"); 30 FILE_PATH_LITERAL("chrome/test/data");
31 31
32 class TestImageFetcherDelegate : public ImageFetcherDelegate { 32 class TestImageFetcherDelegate : public ImageFetcherDelegate {
33 public: 33 public:
34 TestImageFetcherDelegate() 34 TestImageFetcherDelegate()
35 : num_delegate_valid_called_(0), 35 : num_delegate_valid_called_(0),
36 num_delegate_null_called_(0) {} 36 num_delegate_null_called_(0) {}
37 virtual ~TestImageFetcherDelegate() {}; 37 ~TestImageFetcherDelegate() override{};
38 38
39 // Perform additional tasks when an image has been fetched. 39 // Perform additional tasks when an image has been fetched.
40 virtual void OnImageFetched(const GURL& url, const SkBitmap* bitmap) 40 void OnImageFetched(const GURL& url, const SkBitmap* bitmap) override {
41 override {
42 if (bitmap) { 41 if (bitmap) {
43 num_delegate_valid_called_++; 42 num_delegate_valid_called_++;
44 } else { 43 } else {
45 num_delegate_null_called_++; 44 num_delegate_null_called_++;
46 } 45 }
47 }; 46 };
48 47
49 int num_delegate_valid_called() { return num_delegate_valid_called_; } 48 int num_delegate_valid_called() { return num_delegate_valid_called_; }
50 int num_delegate_null_called() { return num_delegate_null_called_; } 49 int num_delegate_null_called() { return num_delegate_null_called_; }
51 50
52 private: 51 private:
53 int num_delegate_valid_called_; 52 int num_delegate_valid_called_;
54 int num_delegate_null_called_; 53 int num_delegate_null_called_;
55 }; 54 };
56 55
57 } // end namespace 56 } // end namespace
58 57
59 class ImageFetcherImplBrowserTest : public InProcessBrowserTest { 58 class ImageFetcherImplBrowserTest : public InProcessBrowserTest {
60 protected: 59 protected:
61 ImageFetcherImplBrowserTest() 60 ImageFetcherImplBrowserTest()
62 : num_callback_valid_called_(0), 61 : num_callback_valid_called_(0),
63 num_callback_null_called_(0), 62 num_callback_null_called_(0),
64 test_server_(net::SpawnedTestServer::TYPE_HTTP, 63 test_server_(net::SpawnedTestServer::TYPE_HTTP,
65 net::SpawnedTestServer::kLocalhost, 64 net::SpawnedTestServer::kLocalhost,
66 base::FilePath(kDocRoot)) {} 65 base::FilePath(kDocRoot)) {}
67 66
68 virtual void SetUpInProcessBrowserTestFixture() override { 67 void SetUpInProcessBrowserTestFixture() override {
69 ASSERT_TRUE(test_server_.Start()); 68 ASSERT_TRUE(test_server_.Start());
70 InProcessBrowserTest::SetUpInProcessBrowserTestFixture(); 69 InProcessBrowserTest::SetUpInProcessBrowserTestFixture();
71 } 70 }
72 71
73 virtual void TearDownInProcessBrowserTestFixture() override { 72 void TearDownInProcessBrowserTestFixture() override { test_server_.Stop(); }
74 test_server_.Stop();
75 }
76 73
77 ImageFetcherImpl* CreateImageFetcher() { 74 ImageFetcherImpl* CreateImageFetcher() {
78 ImageFetcherImpl* fetcher = 75 ImageFetcherImpl* fetcher =
79 new ImageFetcherImpl(browser()->profile()->GetRequestContext()); 76 new ImageFetcherImpl(browser()->profile()->GetRequestContext());
80 fetcher->SetImageFetcherDelegate(&delegate_); 77 fetcher->SetImageFetcherDelegate(&delegate_);
81 return fetcher; 78 return fetcher;
82 } 79 }
83 80
84 void OnImageAvailable(base::RunLoop* loop, 81 void OnImageAvailable(base::RunLoop* loop,
85 const GURL& url, 82 const GURL& url,
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 GURL invalid_image_url(test_server_.GetURL(kInvalidImagePath).spec()); 137 GURL invalid_image_url(test_server_.GetURL(kInvalidImagePath).spec());
141 StartOrQueueNetworkRequestHelper(invalid_image_url); 138 StartOrQueueNetworkRequestHelper(invalid_image_url);
142 139
143 EXPECT_EQ(0, num_callback_valid_called_); 140 EXPECT_EQ(0, num_callback_valid_called_);
144 EXPECT_EQ(1, num_callback_null_called_); 141 EXPECT_EQ(1, num_callback_null_called_);
145 EXPECT_EQ(0, delegate_.num_delegate_valid_called()); 142 EXPECT_EQ(0, delegate_.num_delegate_valid_called());
146 EXPECT_EQ(1, delegate_.num_delegate_null_called()); 143 EXPECT_EQ(1, delegate_.num_delegate_null_called());
147 } 144 }
148 145
149 } // namespace suggestions 146 } // namespace suggestions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698