Issue 648633003: Unify selection rect snapping logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 648633003: Unify selection rect snapping logic (Closed)

Created:
6 years, 2 months ago by eae

Modified:
6 years, 2 months ago

Reviewers:
f(malita)

CC:
blink-reviews, krit, Rik, jbroman, mkwst+moarreviews_chromium.org, danakj, pdr+graphicswatchlist_chromium.org, Stephen Chennney, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Unify selection rect snapping logic Unify the pixel snapping logic for selection rects by moving the logic into selectionRectForText and having selectionRectForSimpleText and selectionRectForComplexText respectively return precise values. R=fmalita@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183632

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -22 lines)			Patch
M	Source/platform/fonts/Font.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/platform/fonts/Font.cpp	View	4 chunks	+11 lines, -12 lines	0 comments	Download
M	Source/platform/fonts/shaping/HarfBuzzShaper.cpp	View	1 chunk	+3 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648633003/1

6 years, 2 months ago (2014-10-14 00:20:45 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-14 00:28:22 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183632

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages