Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 648633002: Oilpan: Scale up the number of marking threads according to available processors (Closed)

Created:
6 years, 2 months ago by haraken
Modified:
6 years, 2 months ago
Reviewers:
oilpan-reviews, sof
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium), mkwst+moarreviews_chromium.org
Project:
blink
Visibility:
Public.

Description

Oilpan: Scale up the number of marking threads according to available processors Currently we use 2 marking threads regardless of the number of processors available. Given that the marking phase takes a substantial amount of time, this CL changes the number of marking threads to min(the number of processors, 4). This CL also decreases the block size of each CallStack from 200 to 128 because load balancing is not good in some benchmarks such as LargeDistributionWithoutLayout. This CL improves LargeDistributionWithoutLayout by 10% for example. BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183613

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M Source/platform/heap/CallbackStack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/Heap.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 1 2 3 4 5 1 chunk +3 lines, -4 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
haraken
PTAL
6 years, 2 months ago (2014-10-10 09:13:51 UTC) #2
sof
lgtm, let's try this. A worry is that the fan out is too aggressive on ...
6 years, 2 months ago (2014-10-13 08:05:21 UTC) #4
haraken
> A worry is that the fan out is too aggressive on power-conscious targets. I ...
6 years, 2 months ago (2014-10-13 15:21:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648633002/170001
6 years, 2 months ago (2014-10-13 15:21:58 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 16:29:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #6 (id:170001) as 183613

Powered by Google App Engine
This is Rietveld 408576698